Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix broken test #1626

Merged
merged 1 commit into from
Dec 11, 2022

Conversation

frozenbonito
Copy link
Contributor

Description

Fix broken docker-in-docker test.

Motivation and Context

#1605 (comment)

@frozenbonito frozenbonito marked this pull request as draft December 10, 2022 11:05
@frozenbonito frozenbonito force-pushed the fix-docker-in-docker-test branch from a4a0178 to de20a0b Compare December 10, 2022 12:02
@frozenbonito
Copy link
Contributor Author

The tests passed in my local environment, but failed in GitHub Actions.
I will close this Pull Request for now because it is difficult to fix this immediately.

@dnalborczyk
Copy link
Collaborator

dnalborczyk commented Dec 10, 2022

thank you for having a look @frozenbonito ! much appreciated! I can have a look a bit later over your PR as well. mind if I re-open in the meanwhile (as a reminder)?

@dnalborczyk dnalborczyk reopened this Dec 10, 2022
@frozenbonito frozenbonito force-pushed the fix-docker-in-docker-test branch from de20a0b to b97945f Compare December 11, 2022 14:59
@frozenbonito
Copy link
Contributor Author

frozenbonito commented Dec 11, 2022

@dnalborczyk
Thank you for comment and re-opening.
I was able to fix it, so I pushed.

@dnalborczyk
Copy link
Collaborator

dnalborczyk commented Dec 11, 2022

thank you for fixing the tests @frozenbonito !!

@dnalborczyk dnalborczyk marked this pull request as ready for review December 11, 2022 18:54
@dnalborczyk dnalborczyk merged commit 87bab9c into dherault:master Dec 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants