Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deprecate use child processes #1546

Merged
merged 1 commit into from
Aug 18, 2022
Merged

fix: deprecate use child processes #1546

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/ServerlessOffline.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import {
defaultOptions,
SERVER_SHUTDOWN_TIMEOUT,
} from './config/index.js'
import { gray } from './config/colors.js'
import { gray, orange } from './config/colors.js'

export default class ServerlessOffline {
#cliOptions = null
Expand Down Expand Up @@ -225,6 +225,14 @@ export default class ServerlessOffline {
...this.#cliOptions,
}

if (this.#options.useChildProcesses) {
log.notice()
log.warning(
orange(`'--useChildProcesses' is deprecated and will be removed in the next major version. Worker threads, the current default, should provide the same if not an even better developer experience.
If you are experiencing any issues please let us know: https://github.com/dherault/serverless-offline/issues`),
)
}

// Parse CORS options
this.#options.corsAllowHeaders = this.#options.corsAllowHeaders
.replace(/\s/g, '')
Expand Down