Update serverless version #1388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduced duplicated code
fixed hanging when python raises exception or return nothing
…uplication Revert "Reduced duplicated code"
…-runner Revert "fixed hanging when python raises exception or return nothing"
…5-fix-python-runner Revert "Revert "fixed hanging when python raises exception or return nothing""
… return nothing"""
…2-revert-1365-fix-python-runner Revert "Revert "Revert "fixed hanging when python raises exception or return nothing"""
Co-authored-by: Luciano Jesus Lima <luciano@doutoraovivo.com.br>
* Move authorizer and identity data to requestContext in order to follow lambda proxy specs * Apply context validation for authorizer * Better route initialization logging
|
hi @AndrewCEmil thank you for the PR!
this should not be the case, as that said, we could still bump the serverless dev dependency to v3. |
|
@AndrewCEmil unfortunately some tests broke with the update. I'll look into this when I find some time. in the meanwhile I reverted back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I updated the serverless version by running
npm i --save-dev serverless@latest.Motivation and Context
Due to 2 different bugs
npm/cli#3210
serverless/serverless#10876
If you have a version of serverless installed by any package, you cannot run a different version. Since serverless-offline includes all of serverless, it will actually force users that don't have serverless installed elsewhere in their project (ie are using a global installation in their dev environment) to use the version provided by serverless-offline.
Because of all this, and because serverless-offline is a major plugin, it seems right that it should be kept up to date with the main serverless package version.
How Has This Been Tested?
I'm not sure the appropriate way to test this. I just ran the updated package locally and confirmed it worked for all my use cases. Sorry for not being more extensive - I'm happy to do more testing, but I'm not sure how.
Screenshots (if appropriate):