Handle multiple cookies with the same name in the same way API Gateway does. #1249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes
serverless-offline's handling of multiple cookies with the same name reflect that of API Gateway.The existing implementation merges cookies with the same name into a single cookie with a comma separated value, i.e. given cookies
foo=bar&foo=baz,APIGatewayProxyEventV2.cookiesresolves tofoo=bar,baz.After the change, cookies with the same name are kept separate, i.e. given cookies
foo=bar&foo=baz,APIGatewayProxyEventV2.cookiesresolves tofoo=bar,foo=baz(as API Gateway behaves).Motivation and Context
The current implementation is not representative.
How Has This Been Tested?
I would be quite happy to add automated tests but I could find no existing precedent for testing code in this class. Please feel free to suggest an automated testing strategy if you would like me to employ one.
I tested my implementation manually using the Node terminal, and tested a build of
serverless-offlinelocally.