Ensure gateway IP is truthy before adding to docker args #1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I am running into a situation on a linux server where the
docker network inspect bridge --format '{{(index .IPAM.Config 0).Gateway}}'command is only returning theSubnetkey in the config and not also theGatewaykey as expected.I don't have control over this particular CI server so I don't know why that is the case. However, this causes the
docker createcommand to fail with an invalid argument for--add-host.This change ensures the gateway IP is truthy before adding to the docker command.
Motivation and Context
This change ensures the output of
docker network inspect bridge --format '{{(index .IPAM.Config 0).Gateway}}'is truthy before adding it to the docker create command.How Has This Been Tested?
This has been tested by running a go lambda on a linux server via
serverless offline --useDocker.