refactor: make payload identifier private static

dherault · Jul 30, 2022 · 7d4bf76 · 7d4bf76
1 parent 4648d39
commit 7d4bf76
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 6 deletions.
diff --git a/src/lambda/handler-runner/java-runner/JavaRunner.js b/src/lambda/handler-runner/java-runner/JavaRunner.js
@@ -7,6 +7,8 @@ const { parse, stringify } = JSON
 const { hasOwn } = Object
 
 export default class JavaRunner {
+  static #payloadIdentifier = '__offline_payload__'
+
   #deployPackage = null
 
   #env = null
@@ -45,9 +47,9 @@ export default class JavaRunner {
       if (
         json &&
         typeof json === 'object' &&
-        hasOwn(json, '__offline_payload__')
+        hasOwn(json, JavaRunner.#payloadIdentifier)
       ) {
-        return json.__offline_payload__
+        return json[JavaRunner.#payloadIdentifier]
       }
     }
 

diff --git a/src/lambda/handler-runner/python-runner/PythonRunner.js b/src/lambda/handler-runner/python-runner/PythonRunner.js
@@ -12,6 +12,8 @@ const { assign, hasOwn } = Object
 const __dirname = dirname(fileURLToPath(import.meta.url))
 
 export default class PythonRunner {
+  static #payloadIdentifier = '__offline_payload__'
+
   #env = null
 
   #handlerName = null
@@ -82,9 +84,9 @@ export default class PythonRunner {
       if (
         json &&
         typeof json === 'object' &&
-        hasOwn(json, '__offline_payload__')
+        hasOwn(json, PythonRunner.#payloadIdentifier)
       ) {
-        payload = json.__offline_payload__
+        payload = json[PythonRunner.#payloadIdentifier]
         // everything else is print(), logging, ...
       } else {
         log.notice(item)

diff --git a/src/lambda/handler-runner/ruby-runner/RubyRunner.js b/src/lambda/handler-runner/ruby-runner/RubyRunner.js
@@ -11,6 +11,8 @@ const { hasOwn } = Object
 const __dirname = dirname(fileURLToPath(import.meta.url))
 
 export default class RubyRunner {
+  static #payloadIdentifier = '__offline_payload__'
+
   #env = null
 
   #handlerName = null
@@ -47,9 +49,9 @@ export default class RubyRunner {
       if (
         json &&
         typeof json === 'object' &&
-        hasOwn(json, '__offline_payload__')
+        hasOwn(json, RubyRunner.#payloadIdentifier)
       ) {
-        payload = json.__offline_payload__
+        payload = json[RubyRunner.#payloadIdentifier]
       } else {
         log.notice(item)
       }