Add typing indicator #127
Add typing indicator #127
Conversation
kaxi1993
commented
Jul 19, 2019
kaxi1993
commented
|
Hey @kaxi1993, thanks for the PR! I haven't had a chance to check it out yet, but can you make sure documentation like the readme is updated too? |
|
Hi @heatherbooker, sure I'll update docs |
There was a problem hiding this comment.
Code structure (new files, indentation) looks great and so do the little jumping dots!
Can the demo be made to work with the indicator? I think that would help
- users understand how to use it
- me understand whether it works ;)
Right now, I'm a bit confused as to the difference between disabling the typing indicator entirely versus it being an appropriate moment to show it (ie, other user is actually typing).
My other comments may become irrelevant depending on the answer to the above :)
@heatherbooker sure I'll add usage of typing in demo and will update you soon |
|
Hey @heatherbooker, I updated demo. When you start typing in textarea, typing indicator appears in chatbot window. I'm going to create chatbot on my website and I want to use react-chat-window. There are times when the server takes 4-5 seconds to respond to user messages, I think this indicator will be helpful in this situations. |
There was a problem hiding this comment.
@kaxi1993 Really solid and greatly appreciated - I just have some minor comments on style to keep the PR consistent with the existing style. More than happy to merge and release this if we can fix those semantic issues.
Thanks again!
|
Hi @dharness, thanks for your feedback. I fixed all of them, please review again and let me know if there is any problem. |
This reverts commit 56e73a7.
- buggy: message background doesn't show This reverts commit 56e73a7.
* Add typing indicator * Update readme to include typing feature * fix sample code issue in readme * Update demo to include typing example * Remove vendor prefixes from typing indicator style * Update typing indicator prop name * Add missing comma
