-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update for hamlib4 #14
base: master
Are you sure you want to change the base?
Conversation
Since this isn't backward compatible with hamlib 3.x, goHamlib will need a v2 branch. I support doing this. |
Hey @dl1igc, thanks for your PR! Very much appreciated. I share the concerns with @xylo04 and I think we should investigate if there is a way to maintain the compatibility with Hamlib 3. We will have to compare what has exactly changed between Hamlib v3 and v4. Maybe we could maintain compatibility with a few additional if/else statements. A v2 branch, as suggested by @xylo04 should be IMHO the last option. |
Thanks for your comments @xylo04 and @dh1tw. I can understand your concerns and share them. If I am not wrong, we have two different compatibility levels. We could probably do the golang code compatible to both libham version over preprocessor directives (#ifdefs and so) but this does not mean that the compiled version will be compatible with both libham versions, I am at the moment not sure that this will work. At the end I think this situation would be even more confusing for end users. I'll give this some deeper thought over the weekend. |
When dh1tw#12 gets resolved, this fork will be obsolete.
Merge from xylo04
With this changes this library is able to compile against libham4. Basic function works with FTDX3000.