forked from kubernetes/ingress-nginx
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
datadog: sample_rate omitted by default #1
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -706,16 +706,9 @@ type Configuration struct { | |
// Default: nginx.handle | ||
DatadogOperationNameOverride string `json:"datadog-operation-name-override"` | ||
|
||
// DatadogPrioritySampling specifies to use client-side sampling | ||
// If true disables client-side sampling (thus ignoring sample_rate) and enables distributed | ||
// priority sampling, where traces are sampled based on a combination of user-assigned | ||
// Default: true | ||
DatadogPrioritySampling bool `json:"datadog-priority-sampling"` | ||
|
||
// DatadogSampleRate specifies sample rate for any traces created. | ||
// This is effective only when datadog-priority-sampling is false | ||
// Default: 1.0 | ||
DatadogSampleRate float32 `json:"datadog-sample-rate"` | ||
// Default: use a dynamic rate instead | ||
DatadogSampleRate *float32 `json:"datadog-sample-rate",omitempty` | ||
|
||
// MainSnippet adds custom configuration to the main section of the nginx configuration | ||
MainSnippet string `json:"main-snippet"` | ||
|
@@ -1001,8 +994,7 @@ func NewDefault() Configuration { | |
DatadogEnvironment: "prod", | ||
DatadogCollectorPort: 8126, | ||
DatadogOperationNameOverride: "nginx.handle", | ||
DatadogSampleRate: 1.0, | ||
DatadogPrioritySampling: true, | ||
DatadogSampleRate: nil, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This shouldn't be needed, except for consistency There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's here for consistency. |
||
LimitReqStatusCode: 503, | ||
LimitConnStatusCode: 503, | ||
SyslogPort: 514, | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is configuration ever printed/serialized after being parsed into this
struct
? If so, non-nil
DatadogSampleRate
would probably render as the pointer value, which is not what we want.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't look like it.