Change DefaultCookieConfig to use the SameSiteLaxMode #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 14df01f.
* Redirecting to a provider's AuthURL as part of Login creates a chain of redirects to the configured backend callback handler to set a session cookie and (typically) redirect to a profile page * Strict cookies would not be sent in the request to the profile page because the redirect chain originated with a redirect to the login provider. The original referrer is used throughout the redirect chain. Because of this browser behavior, most users will need to use SameSite lax mode If you understand the implications, you can still set strict mode: ``` cookieConfig := sessions.DefaultCookieConfig cookieConfig.SameSite = http.SameSiteStrictMode ``` Rel: * https://www.nogginbox.co.uk/blog/strict-cookies-not-sent-by-request * https://bugzilla.mozilla.org/show_bug.cgi?id=1453814
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you understand the implications, you can still set strict mode:
Rel: