Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cookie Config from the Session struct #17

Merged
merged 1 commit into from
Dec 31, 2022
Merged

Remove cookie Config from the Session struct #17

merged 1 commit into from
Dec 31, 2022

Conversation

dghubble
Copy link
Owner

  • A Session should avoid having http.Cookie specific settings such as the cookie Config. Use the CookieStore's cookie Config when setting a new http.Cookie on a http.ResponseWriter
  • Stop exposing the cookie config of each session to callers, which would allow improper Config mutations after a cookie has been issued (confusing)
  • Reorganize cookie Config fields a bit

@dghubble
Remove cookie Config from the Session struct
9c58e16 
* A Session should avoid having http.Cookie specific settings
such as the cookie Config. Use the CookieStore's cookie Config
when setting a new http.Cookie on a http.ResponseWriter
* Stop exposing the cookie config of each session to callers,
which would allow improper Config mutations after a cookie
has been issued (confusing)
* Reorganize cookie Config fields a bit
@dghubble dghubble force-pushed the session-without-cookie-config branch from e8d45c1 to 9c58e16 Compare December 31, 2022 04:08
@dghubble dghubble merged commit 9c58e16 into main Dec 31, 2022
@dghubble dghubble deleted the session-without-cookie-config branch December 31, 2022 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dghubble