-
-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SqLite: Fix fatal error when resource closed prior to result destructing #430
Conversation
I forgot to add that this only happens with PHP 8 and above. |
@dg bump. |
|
I fail to understand the reason for rejecting this PR. If it did not happen I would not have been fixing it. |
How is this different to #431? |
Because getResultResource() returns object. |
Bug fix; bc break: NO
I'm running into an issue in a certain setup with SqLite driver:
See, the resource has already been closed before the destruction of the result object.
Adding
is_resource
check is an efficient way to prevent it, possibly even the suppression operator@
on line 40 might become redundant after this change.I'm guessing this is similar to #409.