Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlsrvDriver: Correct escaping of special characters (N prefix) #332

Merged
merged 4 commits into from
Jul 12, 2019

Conversation

kuty
Copy link
Contributor

@kuty kuty commented Jul 11, 2019

In case nvarchar type is used and e.g. chinese have to be saved, there have to be N in front of the value, this escaping works fine for varchar columns as well.

  • bug fix

In case nvarchar type is used and e.g. chinese have to be saved, there have to be N in front of the value, this escaping works fine for varchar columns as well.
@dg
Copy link
Owner

dg commented Jul 11, 2019

Thanks. Can you fix tests? https://ci.appveyor.com/project/dg/dibi/builds/25896992

@kuty
Copy link
Contributor Author

kuty commented Jul 12, 2019

tests added, tests of like on sqlsrv ar there broken already for some time, such systax is not allowed on MS SQL server

@kuty kuty changed the title Correct escaping of special characters SqlsrvDriver: Correct escaping of special characters (N prefix) Jul 12, 2019
@dg
Copy link
Owner

dg commented Jul 12, 2019

Great, thank you

@dg dg merged commit 0905a8a into dg:master Jul 12, 2019
dg pushed a commit that referenced this pull request Jul 12, 2019
In case nvarchar type is used and e.g. chinese have to be saved, there have to be N in front of the value, this escaping works fine for varchar columns as well.
dg pushed a commit that referenced this pull request Aug 30, 2019
In case nvarchar type is used and e.g. chinese have to be saved, there have to be N in front of the value, this escaping works fine for varchar columns as well.
dg added a commit that referenced this pull request Sep 2, 2024
dg added a commit that referenced this pull request Sep 2, 2024
dg added a commit that referenced this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants