Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Works around trim(char( in inquire #1403

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

bhourahine
Copy link
Member

Either function call on it's own causes problems for Debug

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 70.35%. Comparing base (572c6fb) to head (730249e).
Report is 2 commits behind head on main.

❗ Current head 730249e differs from pull request most recent head 55c0eab. Consider uploading reports for the commit 55c0eab to get more accurate results

Files Patch % Lines
app/phonons/initphonons.F90 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1403      +/-   ##
==========================================
- Coverage   70.65%   70.35%   -0.30%     
==========================================
  Files         231      231              
  Lines       43913    43942      +29     
==========================================
- Hits        31026    30917     -109     
- Misses      12887    13025     +138     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Either function call on it's own causes problems for Debug

Also remove module variable (temporary string)
@bhourahine bhourahine merged commit 8f9f775 into dftbplus:main Mar 6, 2024
5 checks passed
@bhourahine bhourahine deleted the trimWorkAround branch March 6, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants