⬆️ ace-builds

[amyrlam]

With this update, we will get the innerHTML fix from: ajaxorg/ace#3609

Relates to:
#3 @jamesarosen @gschorkopf
ajaxorg/ace#3260

//

I am going to work on a fix for CSS CSP issues, perhaps creating a new theme that is hosted on the web.

[amyrlam]

Whoops, sorry should have run this locally first. I'll take a look at the autocomplete test failures...

[dfreeman]

Thanks for the PR, @amyrlam — I've done a round of ember-cli-update-ing on master that should have Travis happy again. Could you try rebasing on that and seeing if improves things here?

[amyrlam]

@dfreeman Thanks! Rebased, but seems like there are other changes upstream to autocomplete. (Tried going to 1.3.3 but same test failures.)

Been doing some debugging and noticed in autocomplete.js

export const suggestion = {
  selected: is('.ace_selected'), // no class for selected anymore?

  caption: {
    isDescriptor: true,
    get() {
      return this.text.slice(0, -this.meta.length);
    }
  },

  meta: text('.ace_completion-meta'), // prior class no longer there
};

[jamesarosen]

The test is failing because .ace_active-line isn't a modifier that gets added to the currently selected .ace_line. It's a completely separate element in a completely separate part of the DOM that happens to have the same X/Y coordinates. I can't think of a good way to express that as a jQuery selector like is('.ace_selected').

[jamesarosen]

When we were running this locally, it looked like ACE's autocomplete might be putting them in the opposite order and using top to visually change the order. Just one more way ACE is anti-accessibility.

[amyrlam]

closing, solved by #28, thank you so much for your help! 🌟

[dfreeman]

Thanks for your work getting this started, @amyrlam and @jamesarosen!