Title fix (Issues #182 and #89)

[jeremytbrun]

This PR is an attempt at fixing both issues #182 and #89.

Attached is a test script to reproduce the issues in old and new code.

ImportExcelPRSample.zip

[dfinke]

hey @jeremytbrun this is what I get running your changes. Is this right?

[jeremytbrun]

@dfinke Well that's odd. That is definitely not what I get when I run the sample script I originally attached. Can you provide the exact command you are running?

[jeremytbrun]

@dfinke The sample script I attached should yield this.

[dfinke]

OK, I'll clone it again and double check my local machine has no other modules.

[dfinke]

Weird, git clone https://github.com/jeremytbrun/ImportExcel.git. My machine has no other installs and I get the results I posted.

[jeremytbrun]

Are you cloning the master repository (copy of yours) or the TitleFix repository?

[jeremytbrun]

Sorry, I mean TitleFix branch. That is what contains the fixes. Master branch is merely a clone of yours.

[dfinke]

Sorry, my fault. Looks good. I'll take it through it paces a bit more.

Please could you also update the readme.md?

[dfinke]

This is great, it's looking good.

[jeremytbrun]

Sure, I'll update the readme tonight or tomorrow. Jeremy

…

On Mon, Oct 2, 2017, 17:52 Doug Finke ***@***.***> wrote: This is great, it's looking good. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#228 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AbABimb_m2njPgi6eGWe7xn4oge5MPqjks5soVscgaJpZM4PqsoM> .

[jeremytbrun]

@dfinke README.md updated. Let me know if there is anything else I should add. Thanks for the pointers!

[dfinke]

@jeremytbrun, @DarkLite1 I published a new version to the gallery

[DarkLite1]

Good job guys! 👍