Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Empty commit to resolve #446 #456

Merged
1 commit merged into from
Mar 13, 2020
Merged

Chore: Empty commit to resolve #446 #456

1 commit merged into from
Mar 13, 2020

Conversation

ghost
Copy link

@ghost ghost commented Mar 13, 2020

No description provided.

@ghost ghost self-assigned this Mar 13, 2020
@ghost ghost marked this pull request as ready for review March 13, 2020 20:46
@ghost ghost requested a review from hansl March 13, 2020 20:47
@ghost
Copy link
Author

ghost commented Mar 13, 2020

Hey @hansl , can you leave a review here but not approve yet?

Copy link
Contributor

@hansl hansl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes. Because why not? I’m just drunk on reviewer power!

@ghost ghost requested a review from hansl March 13, 2020 20:50
@ghost
Copy link
Author

ghost commented Mar 13, 2020

I've made your requested changes, under protest. Review again, @hansl ?

Copy link
Contributor

@hansl hansl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah much better.

@ghost ghost merged commit d4b2243 into master Mar 13, 2020
@ghost ghost deleted the sj/sdk-project-testing branch March 13, 2020 20:53
dfinity-bot added a commit that referenced this pull request Oct 31, 2020
## Changelog for advisory-db:
Branch: master
Commits: [rustsec/advisory-db@09a8d7b2...a0e59ff2](rustsec/advisory-db@09a8d7b...a0e59ff)

* [`a36b1185`](rustsec/advisory-db@a36b118) Add advisory for data race fix in futures-util ([RustSec/advisory-db⁠#455](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/455))
* [`9cd2504f`](rustsec/advisory-db@9cd2504) Assigned RUSTSEC-2020-0059 to futures-util ([RustSec/advisory-db⁠#456](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/456))
* [`b78fac19`](rustsec/advisory-db@b78fac1) Bumped create-pull-request github action to v3 ([RustSec/advisory-db⁠#457](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/457))
* [`6a31581e`](rustsec/advisory-db@6a31581) Add advisory for use-after-free in futures-util task::waker
* [`8c7efa1d`](rustsec/advisory-db@8c7efa1) Add advisory for potential null pointer deref in futures-task
* [`47bfd9f2`](rustsec/advisory-db@47bfd9f) Add advisory for unsound Sync implemention on FuturesUnordered in futures-util
* [`338f0977`](rustsec/advisory-db@338f097) Assigned RUSTSEC-2020-0060 to futures-task
* [`e4784fd3`](rustsec/advisory-db@e4784fd) Assigned RUSTSEC-2020-0061 to futures-task
* [`52cd1035`](rustsec/advisory-db@52cd103) Assigned RUSTSEC-2020-0062 to futures-util
@Dfinity-Anthony Dfinity-Anthony unassigned ghost Jun 18, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant