Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unwraps (for commands) #147

Merged
merged 14 commits into from
Dec 6, 2019
Merged

Remove unwraps (for commands) #147

merged 14 commits into from
Dec 6, 2019

Conversation

eftychis
Copy link
Contributor

@eftychis eftychis commented Nov 7, 2019

No description provided.

@eftychis eftychis force-pushed the eftychis-remove-unwraps branch 3 times, most recently from 5d3105e to 3904f22 Compare November 8, 2019 09:42
@eftychis eftychis marked this pull request as ready for review November 8, 2019 09:42
@eftychis eftychis requested a review from a team as a code owner November 8, 2019 09:42
@eftychis eftychis force-pushed the eftychis-remove-unwraps branch 2 times, most recently from 166920d to 21401cd Compare November 8, 2019 09:48
@eftychis eftychis changed the title Remove unwraps Remove unwraps (for commands) Nov 8, 2019
ghost
ghost reviewed Nov 8, 2019
View reviewed changes
dfx/src/lib/error.rs Outdated Show resolved Hide resolved
hansl
hansl reviewed Nov 8, 2019
View reviewed changes
dfx/src/commands/build.rs Outdated Show resolved Hide resolved
hansl
hansl reviewed Nov 8, 2019
View reviewed changes
dfx/src/commands/build.rs Outdated Show resolved Hide resolved
hansl
hansl reviewed Nov 8, 2019
View reviewed changes
dfx/src/commands/new.rs Outdated Show resolved Hide resolved
hansl
hansl suggested changes Nov 8, 2019
View reviewed changes
Copy link
Contributor

@hansl hansl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits and comments. Otherwise good work!

@eftychis eftychis mentioned this pull request Nov 11, 2019
Merged
@eftychis eftychis requested a review from hansl December 2, 2019 23:34
@eftychis
Copy link
Contributor Author

eftychis commented Dec 2, 2019 •
edited
Loading

TODO:

  • Squash with fix: prefix once ready to merge.

hansl
hansl reviewed Dec 3, 2019
View reviewed changes
dfx/src/commands/new.rs Outdated
@@ -127,6 +130,10 @@ where
}

let mut new_project_files = assets::new_project_files()?;
let project_name_str = project_name
.to_str()
.ok_or_else(|| DfxError::InvalidArgument("project name".to_string()))?;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Snake case.

hansl
hansl reviewed Dec 3, 2019
View reviewed changes
dfx/src/commands/new.rs Outdated
let s = s.replace("{dfx_version}", dfx_version);

// Perform path replacements.
let p = PathBuf::from(
project_name
.join(file.header().path()?)
.to_str()
.unwrap()
.ok_or_else(|| {
DfxError::InvalidArgument("project name path or file header".to_string())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should never happen. Maybe we need an Impossible(String) error variant for cases like these? This would only happen if a non-UTF8 character is in the path, which would break above for project_name and in the build script for file.header().path().

hansl
hansl reviewed Dec 3, 2019
View reviewed changes
dfx/src/config/dfinity.rs Outdated
)?;
let json_pretty = serde_json::to_string_pretty(&self.json).or_else(|e| {
Err(DfxError::InvalidData(format!(
"Failed to serialize -- {}",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Failed to serialize dfx.json: {}" for consistency with other error messages.

hansl
hansl suggested changes Dec 3, 2019
View reviewed changes
Copy link
Contributor

@hansl hansl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes in general, but it's a good improvement!

eftychis
eftychis commented Dec 3, 2019
View reviewed changes
dfx/src/commands/canister/request_status.rs Outdated
.value_of("request_id")
.ok_or_else(|| DfxError::InvalidArgument("request_id".to_string()))?[2..],
)
.map_err(|e| DfxError::ICContainerError(format!("invalid request ID: {:?}", e)))?; // FIXME Default formatter for RequestIdFromStringError
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to map our RequestIdError to a DfxError. I added a generic type for IC related errors. I can do some house cleaning in the request Id and expose a common Request Id error type (right now it is a bit fragmented.

Note: Adding a generic on the error trait pollutes everything as it is not sized and needs to carry a lifetime, so I avoided it. I am happy to do that as a follow up, or do something more intricate when I feel better, but I think it goes beyond the scope of this PR and would like to close this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an InvalidArgument error. It should also never happen, since we have a validator for it.

@eftychis eftychis requested a review from hansl December 3, 2019 22:12
hansl
hansl reviewed Dec 5, 2019
View reviewed changes
dfx/src/commands/canister/call.rs Outdated

let method_name = args.value_of("method_name").unwrap();
let method_name = args.value_of("method_name").ok_or_else(|| {
DfxError::InvalidArgument("method name argument provided invalid".to_string())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"method_name"

hansl
hansl reviewed Dec 5, 2019
View reviewed changes
dfx/src/lib/error/mod.rs Outdated Show resolved Hide resolved
hansl
hansl reviewed Dec 5, 2019
View reviewed changes
dfx/src/lib/error/mod.rs Outdated Show resolved Hide resolved
hansl
hansl reviewed Dec 5, 2019
View reviewed changes
dfx/src/lib/error/mod.rs Outdated Show resolved Hide resolved
hansl
hansl reviewed Dec 5, 2019
View reviewed changes
dfx/src/commands/new.rs Outdated Show resolved Hide resolved
hansl
hansl reviewed Dec 6, 2019
View reviewed changes
dfx/src/commands/new.rs Outdated Show resolved Hide resolved
hansl
hansl reviewed Dec 6, 2019
View reviewed changes
dfx/src/commands/new.rs Outdated Show resolved Hide resolved
hansl
hansl reviewed Dec 6, 2019
View reviewed changes
dfx/src/commands/new.rs Outdated Show resolved Hide resolved
@eftychis
Copy link
Contributor Author

eftychis commented Dec 6, 2019

@hansl 👋

@eftychis eftychis merged commit 7c96638 into master Dec 6, 2019
@eftychis eftychis deleted the eftychis-remove-unwraps branch December 6, 2019 22:16
dfinity-bot added a commit that referenced this pull request Feb 15, 2022
@dfinity-bot
build: niv advisory-db: update dd7d3d72 -> 97388358
03f3d70 
## Changelog for advisory-db:
Branch: main
Commits: [rustsec/advisory-db@dd7d3d72...97388358](rustsec/advisory-db@dd7d3d7...9738835)

* [`3952f343`](rustsec/advisory-db@3952f34) Mark arrow advisories as fixed in apache/arrow-rs#817 ([RustSec/advisory-db⁠#1131](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1131))
* [`7f0874b5`](rustsec/advisory-db@7f0874b) Mark cargo-download unmaintained ([RustSec/advisory-db⁠#1132](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1132))
* [`1ea676a6`](rustsec/advisory-db@1ea676a) Assigned RUSTSEC-2021-0133 to cargo-download ([RustSec/advisory-db⁠#1133](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1133))
* [`a20a779b`](rustsec/advisory-db@a20a779) Turn the issue about shamir into an advisory ([RustSec/advisory-db⁠#1134](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1134))
* [`de2da259`](rustsec/advisory-db@de2da25) Assigned RUSTSEC-2020-0160 to shamir ([RustSec/advisory-db⁠#1135](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1135))
* [`2b51ce82`](rustsec/advisory-db@2b51ce8) Report that rental is no longer maintained ([RustSec/advisory-db⁠#1136](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1136))
* [`dcf8fb2a`](rustsec/advisory-db@dcf8fb2) Assigned RUSTSEC-2021-0134 to rental ([RustSec/advisory-db⁠#1137](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1137))
* [`0bc31953`](rustsec/advisory-db@0bc3195) Add unmaintained advisory for lmdb ([RustSec/advisory-db⁠#1142](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1142))
* [`9997408c`](rustsec/advisory-db@9997408) Assigned RUSTSEC-2022-0001 to lmdb ([RustSec/advisory-db⁠#1143](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1143))
* [`97798466`](rustsec/advisory-db@9779846) README.md: bump maintained date
* [`14b4f228`](rustsec/advisory-db@14b4f22) RUSTSEC-2016-0015: remove `sodiumoxide` recommendation ([RustSec/advisory-db⁠#1145](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1145))
* [`61d8acaf`](rustsec/advisory-db@61d8aca) Undefined behavior in `dashmap` ([RustSec/advisory-db⁠#1146](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1146))
* [`36e44b1f`](rustsec/advisory-db@36e44b1) Assigned RUSTSEC-2022-0002 to dashmap ([RustSec/advisory-db⁠#1148](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1148))
* [`2e646db5`](rustsec/advisory-db@2e646db) Add CVE to RUSTSEC-2021-0124 ([RustSec/advisory-db⁠#1149](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1149))
* [`770c8cad`](rustsec/advisory-db@770c8ca) Add rust-ammonia/ammonia[RustSec/advisory-db⁠#147](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/147) ([RustSec/advisory-db⁠#1152](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1152))
* [`bf972ed7`](rustsec/advisory-db@bf972ed) Assigned RUSTSEC-2022-0003 to ammonia ([RustSec/advisory-db⁠#1153](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1153))
* [`aad861dd`](rustsec/advisory-db@aad861d) Add advisory for CVE-2022-21658 ([RustSec/advisory-db⁠#1155](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1155))
* [`d4c65da0`](rustsec/advisory-db@d4c65da) Correct year for CVE-2022-21658 ([RustSec/advisory-db⁠#1157](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1157))
* [`ff5b4456`](rustsec/advisory-db@ff5b445) Add advisory for tower-http[RustSec/advisory-db⁠#204](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/204) ([RustSec/advisory-db⁠#1159](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1159))
* [`3e8ee098`](rustsec/advisory-db@3e8ee09) Assigned RUSTSEC-2021-0135 to tower-http ([RustSec/advisory-db⁠#1160](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1160))
* [`b0dce59b`](rustsec/advisory-db@b0dce59) Fix version specification in CVE-2022-21658 ([RustSec/advisory-db⁠#1161](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1161))
* [`d1235dbb`](rustsec/advisory-db@d1235db) Add advisory for array-macro ([RustSec/advisory-db⁠#1162](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1162))
* [`258329ba`](rustsec/advisory-db@258329b) Assigned RUSTSEC-2020-0161 to array-macro ([RustSec/advisory-db⁠#1163](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1163))
* [`3e6d7719`](rustsec/advisory-db@3e6d771) Add advisory for rustc_serialize ([RustSec/advisory-db⁠#1140](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1140))
* [`5a24458f`](rustsec/advisory-db@5a24458) Assigned RUSTSEC-2022-0004 to rustc-serialize ([RustSec/advisory-db⁠#1164](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1164))
* [`190dfb9d`](rustsec/advisory-db@190dfb9) Update which tower-http versions are affected by RUSTSEC-2021-0135 ([RustSec/advisory-db⁠#1166](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1166))
* [`e8f33f7e`](rustsec/advisory-db@e8f33f7) Add unmaintained crate advisory for `ftd2xx-embedded-hal` ([RustSec/advisory-db⁠#1167](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1167))
* [`0ca65bbd`](rustsec/advisory-db@0ca65bb) Assigned RUSTSEC-2022-0005 to ftd2xx-embedded-hal ([RustSec/advisory-db⁠#1168](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1168))
* [`1ecfb4a3`](rustsec/advisory-db@1ecfb4a) Add advisory for Amanieu/thread_local-rs[RustSec/advisory-db⁠#33](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/33) ([RustSec/advisory-db⁠#1169](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1169))
* [`9839c6ee`](rustsec/advisory-db@9839c6e) Assigned RUSTSEC-2022-0006 to thread_local ([RustSec/advisory-db⁠#1170](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1170))
* [`3c8a9dc3`](rustsec/advisory-db@3c8a9dc) Add qcell crate advisory ([RustSec/advisory-db⁠#1171](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1171))
* [`9da1eb7e`](rustsec/advisory-db@9da1eb7) Assigned RUSTSEC-2022-0007 to qcell ([RustSec/advisory-db⁠#1172](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1172))
* [`989da550`](rustsec/advisory-db@989da55) Add advisory for windows ([RustSec/advisory-db⁠#1177](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1177))
* [`c9a98f3b`](rustsec/advisory-db@c9a98f3) Assigned RUSTSEC-2022-0008 to windows ([RustSec/advisory-db⁠#1178](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1178))
* [`b2a864d3`](rustsec/advisory-db@b2a864d) Add patched version to DashMap advisory ([RustSec/advisory-db⁠#1181](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1181))
* [`ec4cc26a`](rustsec/advisory-db@ec4cc26) Add entry for libp2p-core vulnerability ([RustSec/advisory-db⁠#1182](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1182))
* [`8f550f12`](rustsec/advisory-db@8f550f1) Assigned RUSTSEC-2022-0009 to libp2p-core ([RustSec/advisory-db⁠#1183](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1183))
* [`ff3a5264`](rustsec/advisory-db@ff3a526) Mark tokio-proto as deprecated ([RustSec/advisory-db⁠#1184](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1184))
* [`17946d71`](rustsec/advisory-db@17946d7) Assigned RUSTSEC-2020-0162 to tokio-proto ([RustSec/advisory-db⁠#1185](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1185))
* [`90790107`](rustsec/advisory-db@9079010) Update RUSTSEC-2022-0009.md ([RustSec/advisory-db⁠#1186](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1186))
* [`97388358`](rustsec/advisory-db@9738835) Suggest maintained alternatives for Rental advisory ([RustSec/advisory-db⁠#1187](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1187))
mergify bot pushed a commit that referenced this pull request Feb 15, 2022
@dfinity-bot
build: niv advisory-db: update dd7d3d72 -> 97388358 (#2030)
cf6795e 
## Changelog for advisory-db:
Branch: main
Commits: [rustsec/advisory-db@dd7d3d72...97388358](rustsec/advisory-db@dd7d3d7...9738835)

* [`3952f343`](rustsec/advisory-db@3952f34) Mark arrow advisories as fixed in apache/arrow-rs#817 ([RustSec/advisory-db⁠#1131](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1131))
* [`7f0874b5`](rustsec/advisory-db@7f0874b) Mark cargo-download unmaintained ([RustSec/advisory-db⁠#1132](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1132))
* [`1ea676a6`](rustsec/advisory-db@1ea676a) Assigned RUSTSEC-2021-0133 to cargo-download ([RustSec/advisory-db⁠#1133](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1133))
* [`a20a779b`](rustsec/advisory-db@a20a779) Turn the issue about shamir into an advisory ([RustSec/advisory-db⁠#1134](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1134))
* [`de2da259`](rustsec/advisory-db@de2da25) Assigned RUSTSEC-2020-0160 to shamir ([RustSec/advisory-db⁠#1135](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1135))
* [`2b51ce82`](rustsec/advisory-db@2b51ce8) Report that rental is no longer maintained ([RustSec/advisory-db⁠#1136](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1136))
* [`dcf8fb2a`](rustsec/advisory-db@dcf8fb2) Assigned RUSTSEC-2021-0134 to rental ([RustSec/advisory-db⁠#1137](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1137))
* [`0bc31953`](rustsec/advisory-db@0bc3195) Add unmaintained advisory for lmdb ([RustSec/advisory-db⁠#1142](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1142))
* [`9997408c`](rustsec/advisory-db@9997408) Assigned RUSTSEC-2022-0001 to lmdb ([RustSec/advisory-db⁠#1143](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1143))
* [`97798466`](rustsec/advisory-db@9779846) README.md: bump maintained date
* [`14b4f228`](rustsec/advisory-db@14b4f22) RUSTSEC-2016-0015: remove `sodiumoxide` recommendation ([RustSec/advisory-db⁠#1145](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1145))
* [`61d8acaf`](rustsec/advisory-db@61d8aca) Undefined behavior in `dashmap` ([RustSec/advisory-db⁠#1146](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1146))
* [`36e44b1f`](rustsec/advisory-db@36e44b1) Assigned RUSTSEC-2022-0002 to dashmap ([RustSec/advisory-db⁠#1148](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1148))
* [`2e646db5`](rustsec/advisory-db@2e646db) Add CVE to RUSTSEC-2021-0124 ([RustSec/advisory-db⁠#1149](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1149))
* [`770c8cad`](rustsec/advisory-db@770c8ca) Add rust-ammonia/ammonia[RustSec/advisory-db⁠#147](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/147) ([RustSec/advisory-db⁠#1152](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1152))
* [`bf972ed7`](rustsec/advisory-db@bf972ed) Assigned RUSTSEC-2022-0003 to ammonia ([RustSec/advisory-db⁠#1153](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1153))
* [`aad861dd`](rustsec/advisory-db@aad861d) Add advisory for CVE-2022-21658 ([RustSec/advisory-db⁠#1155](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1155))
* [`d4c65da0`](rustsec/advisory-db@d4c65da) Correct year for CVE-2022-21658 ([RustSec/advisory-db⁠#1157](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1157))
* [`ff5b4456`](rustsec/advisory-db@ff5b445) Add advisory for tower-http[RustSec/advisory-db⁠#204](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/204) ([RustSec/advisory-db⁠#1159](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1159))
* [`3e8ee098`](rustsec/advisory-db@3e8ee09) Assigned RUSTSEC-2021-0135 to tower-http ([RustSec/advisory-db⁠#1160](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1160))
* [`b0dce59b`](rustsec/advisory-db@b0dce59) Fix version specification in CVE-2022-21658 ([RustSec/advisory-db⁠#1161](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1161))
* [`d1235dbb`](rustsec/advisory-db@d1235db) Add advisory for array-macro ([RustSec/advisory-db⁠#1162](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1162))
* [`258329ba`](rustsec/advisory-db@258329b) Assigned RUSTSEC-2020-0161 to array-macro ([RustSec/advisory-db⁠#1163](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1163))
* [`3e6d7719`](rustsec/advisory-db@3e6d771) Add advisory for rustc_serialize ([RustSec/advisory-db⁠#1140](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1140))
* [`5a24458f`](rustsec/advisory-db@5a24458) Assigned RUSTSEC-2022-0004 to rustc-serialize ([RustSec/advisory-db⁠#1164](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1164))
* [`190dfb9d`](rustsec/advisory-db@190dfb9) Update which tower-http versions are affected by RUSTSEC-2021-0135 ([RustSec/advisory-db⁠#1166](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1166))
* [`e8f33f7e`](rustsec/advisory-db@e8f33f7) Add unmaintained crate advisory for `ftd2xx-embedded-hal` ([RustSec/advisory-db⁠#1167](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1167))
* [`0ca65bbd`](rustsec/advisory-db@0ca65bb) Assigned RUSTSEC-2022-0005 to ftd2xx-embedded-hal ([RustSec/advisory-db⁠#1168](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1168))
* [`1ecfb4a3`](rustsec/advisory-db@1ecfb4a) Add advisory for Amanieu/thread_local-rs[RustSec/advisory-db⁠#33](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/33) ([RustSec/advisory-db⁠#1169](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1169))
* [`9839c6ee`](rustsec/advisory-db@9839c6e) Assigned RUSTSEC-2022-0006 to thread_local ([RustSec/advisory-db⁠#1170](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1170))
* [`3c8a9dc3`](rustsec/advisory-db@3c8a9dc) Add qcell crate advisory ([RustSec/advisory-db⁠#1171](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1171))
* [`9da1eb7e`](rustsec/advisory-db@9da1eb7) Assigned RUSTSEC-2022-0007 to qcell ([RustSec/advisory-db⁠#1172](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1172))
* [`989da550`](rustsec/advisory-db@989da55) Add advisory for windows ([RustSec/advisory-db⁠#1177](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1177))
* [`c9a98f3b`](rustsec/advisory-db@c9a98f3) Assigned RUSTSEC-2022-0008 to windows ([RustSec/advisory-db⁠#1178](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1178))
* [`b2a864d3`](rustsec/advisory-db@b2a864d) Add patched version to DashMap advisory ([RustSec/advisory-db⁠#1181](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1181))
* [`ec4cc26a`](rustsec/advisory-db@ec4cc26) Add entry for libp2p-core vulnerability ([RustSec/advisory-db⁠#1182](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1182))
* [`8f550f12`](rustsec/advisory-db@8f550f1) Assigned RUSTSEC-2022-0009 to libp2p-core ([RustSec/advisory-db⁠#1183](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1183))
* [`ff3a5264`](rustsec/advisory-db@ff3a526) Mark tokio-proto as deprecated ([RustSec/advisory-db⁠#1184](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1184))
* [`17946d71`](rustsec/advisory-db@17946d7) Assigned RUSTSEC-2020-0162 to tokio-proto ([RustSec/advisory-db⁠#1185](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1185))
* [`90790107`](rustsec/advisory-db@9079010) Update RUSTSEC-2022-0009.md ([RustSec/advisory-db⁠#1186](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1186))
* [`97388358`](rustsec/advisory-db@9738835) Suggest maintained alternatives for Rental advisory ([RustSec/advisory-db⁠#1187](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1187))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hansl hansl hansl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eftychis @hansl