-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for install arguments on deploy #1087
Conversation
Co-authored-by: Yan Chen <48968912+chenyan-dfinity@users.noreply.github.com>
Note: There is no way to have the type of the init function as it is not part of the DID file, unfortunately. This means you need to properly type the arguments. Also, to avoid confusion with canister name, I had to specify an actual argument name ( |
It is part of the did file, see: https://github.com/dfinity-lab/sdk/blob/802a1a4a7e85f3c27ba74f39d2d804bfcb9bbe35/src/dfx/src/commands/canister/install.rs#L132 |
@chenyan-dfinity mmmh I'll add candid resolution then. This will happen per canister, though, and means if one argument is "Text" and the other is "Nat", it will work with the first and fail with the second. Makes sense? |
Yes, it's the same behavior with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.