feat(frontend): add edge case for SOL txn from and to my wallet #4123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om-and-to-my-wallet' into feat(frontend)/handle-sol-txn-from-and-to-my-wallet # Conflicts: # src/frontend/src/sol/utils/sol-transactions.utils.ts
loki344
deleted the
feat(frontend)/handle-sol-txn-from-and-to-my-wallet
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add the edge case where a user sends an amount from his wallet, to his wallet. Due to the hard coded values of the from and to in the mapper, this is handled wrongly. In these cases, the SOL transaction only includes 3 Accountkeys: My wallet, the SOL System Program, and the SOL Compute Budget program. This case needs special handling which is introduced by a ternary in the mapper.
Changes
Add SystemAccountKeys from SOL to filter them out. Add edge case in mapping functionality to have correct recipient.
Tests
Unit test added for this case