feat(frontend): adds vip qr code item to the menu #3990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BonomoAlessandro
changed the title
…r-codes-option-in-menu' into feature(frontend)/displays-vip-qr-codes-option-in-menu # Conflicts: # src/declarations/backend/backend.did.d.ts
…r-codes-option-in-menu' into feature(frontend)/displays-vip-qr-codes-option-in-menu
…plays-vip-qr-codes-option-in-menu # Conflicts: # src/frontend/src/lib/components/core/Menu.svelte
…lements-reward-canister-api
…feature(frontend)/displays-vip-qr-codes-option-in-menu
removes unused code
…feature(frontend)/displays-vip-qr-codes-option-in-menu
…plays-vip-qr-codes-option-in-menu # Conflicts: # src/frontend/src/lib/i18n/en.json # src/frontend/src/lib/services/reward-code.services.ts # src/frontend/src/lib/types/i18n.d.ts # src/frontend/src/tests/lib/services/reward-code.services.spec.ts
| @@ -42,6 +48,17 @@ | |||
|
|
|||
| let fromRoute: NavigationTarget | null; | |||
|
|
|||
| let isVip = false; | |||
| onMount(async () => { | |||
There was a problem hiding this comment.
will this run everytime we open the Menu? should it be maybe a state somewhere?
There was a problem hiding this comment.
hmm it might be a good idea to but it into a state instead of calling every time
There was a problem hiding this comment.
@AntonioVentilii ok nevermind. I don't think that it is necessary to store the state somewhere. The Menu item is only loaded one time and the vip data are loaded in the onMount function.
BonomoAlessandro
commented
Jan 7, 2025
| <ButtonMenu | ||
| ariaLabel={$i18n.navigation.alt.vip_qr_code} | ||
| testId={NAVIGATION_MENU_VIP_BUTTON} | ||
| on:click={() => {}} |
There was a problem hiding this comment.
For now nothing happens if the menu button is clicked. This is implemented in another PR.
There was a problem hiding this comment.
just add a TODO before merging
AntonioVentilii
approved these changes
Jan 7, 2025
| <ButtonMenu | ||
| ariaLabel={$i18n.navigation.alt.vip_qr_code} | ||
| testId={NAVIGATION_MENU_VIP_BUTTON} | ||
| on:click={() => {}} |
There was a problem hiding this comment.
just add a TODO before merging
BonomoAlessandro
deleted the
feature(frontend)/displays-vip-qr-codes-option-in-menu
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Vip users should be able to see the
VIP QR codesitem into the menu.Changes
Tests
before:
after:
