Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add beta network to dfx.json #5743

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add beta network to dfx.json #5743

wants to merge 1 commit into from

Conversation

dskloetd
Copy link
Contributor

@dskloetd dskloetd commented Nov 7, 2024

Motivation

We are currently using the app network canister for the beta release.
We want to move the beta release to Orbit for more secure management and make the app canister available of ad-hoc testing again.

Changes

  1. Add a beta network to dfx.json which has all the same values as mainnet and app except for the nns-dapp canister ID, which is the one controlled by the NNS team Orbit station.
  2. Set IS_TEST_MAINNET to true for the beta network in addition to the app network so that we show the warning banner.

Tests

  1. Manually tested that the warning banner is show when the network is set to beta or app.
  2. Ran DFX_NETWORK=beta ./config.sh and inspected that the arguments are as described here.

Todos

  • Add entry to changelog (if necessary).
    not necessary

@dskloetd dskloetd marked this pull request as ready for review November 7, 2024 20:20
@dskloetd dskloetd requested a review from a team as a code owner November 7, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant