Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: login screen minor changes #1799

Merged
merged 5 commits into from
Feb 2, 2023
Merged

feat: login screen minor changes #1799

merged 5 commits into from
Feb 2, 2023

Conversation

peterpeterparker
Copy link
Member

Motivation

Requested login screen changes.

Requested changes

  • remove copyright
  • remove about
  • add link to dashboard
  • add link to internetcomputer.org
  • update "Total Value Locked" to "Total ICP Value Locked"

Changes

  • as requested
  • use extra large breakpoints instead of large to avoid ugly layout
  • bump gix cmp to use such constant

Screenshots

Capture d’écran 2023-02-01 à 17 20 14

Capture d’écran 2023-02-01 à 17 20 17

Capture d’écran 2023-02-01 à 17 20 19

Capture d’écran 2023-02-01 à 17 20 20

Capture d’écran 2023-02-01 à 17 20 26

Capture d’écran 2023-02-01 à 17 20 28

Capture d’écran 2023-02-01 à 17 21 23

Capture d’écran 2023-02-01 à 17 21 28

Capture d’écran 2023-02-01 à 17 21 31

Capture d’écran 2023-02-01 à 17 21 37

Capture d’écran 2023-02-01 à 17 21 39

Capture d’écran 2023-02-01 à 17 21 41

Capture d’écran 2023-02-01 à 17 22 06

Capture d’écran 2023-02-01 à 17 22 08

Capture d’écran 2023-02-01 à 17 22 09

Capture d’écran 2023-02-01 à 17 22 11

mstrasinskis
mstrasinskis approved these changes Feb 2, 2023
View reviewed changes
Copy link
Contributor

@mstrasinskis mstrasinskis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@peterpeterparker peterpeterparker enabled auto-merge (squash) February 2, 2023 13:02
@peterpeterparker peterpeterparker enabled auto-merge (squash) February 2, 2023 13:03
@peterpeterparker peterpeterparker merged commit 63c6a58 into main Feb 2, 2023
@peterpeterparker peterpeterparker deleted the feat/login-screen-minor-changes branch February 2, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstrasinskis mstrasinskis mstrasinskis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterpeterparker @mstrasinskis