Skip to content

Commit

Permalink
Remove split-assets script (#5616)
Browse files Browse the repository at this point in the history
# Motivation

The `split-assets` script was used to create asset chunks to upload to
an nns-dapp wasm that was deployed without assets.
This functionality was remove in
#5615 so there is no need
anymore for this script.

# Changes

Remove `scripts/nns-dapp/split-assets`.

# Tests

1. Remove `scripts/nns-dapp/split-assets.test`.
2. Stop running `scripts/nns-dapp/split-assets.test` in
`.github/workflows/checks.yml`.

# Todos

- [ ] Add entry to changelog (if necessary).
not necessary
  • Loading branch information
dskloetd authored Oct 15, 2024
1 parent 994d8e6 commit b828d67
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 180 deletions.
8 changes: 0 additions & 8 deletions .github/workflows/checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -196,13 +196,6 @@ jobs:
cargo binstall --no-confirm "idl2json_cli@$(jq -r .defaults.build.config.IDL2JSON_VERSION dfx.json)"
- name: Check mainnet config
run: bash -x config.test
asset-chunking-works:
name: Asset chunking works
runs-on: ubuntu-20.04
steps:
- uses: actions/checkout@v4
- name: Test chunking
run: scripts/nns-dapp/split-assets.test
migration-test-utils-work:
name: Migration test utilities work
runs-on: ubuntu-20.04
Expand Down Expand Up @@ -355,7 +348,6 @@ jobs:
- ic-commit-consistency
- release-templating-works
- config-check
- asset-chunking-works
- minor-version-bump-works
- migration-test-utils-work
- version-match
Expand Down
98 changes: 0 additions & 98 deletions scripts/nns-dapp/split-assets

This file was deleted.

74 changes: 0 additions & 74 deletions scripts/nns-dapp/split-assets.test

This file was deleted.

0 comments on commit b828d67

Please sign in to comment.