Skip to content

Commit

Permalink
Fix mistakenly introduced code changes (#5574)
Browse files Browse the repository at this point in the history
# Motivation

NnsNeuronAge has label but all the other keyValue pairs don't. This was
introduced by mistake in [here
](https://github.com/dfinity/nns-dapp/pull/5516/files#diff-8fdc14d15bb871489f65e3413e08042acdf48c6eed95ecea2ce5cacd745b705bR23).
There was a time all the key value pairs had the correct color according
to Figma in referenced pr. When reverting style changes, I forgot to
delete this one. It looks like it passed by in between all other code
changes as this looks like a small style update.

As you can see in the screenshots it is also not easily noticeable.

# Changes

Delete wrong styling for NnsNeuronAge

# Tests

screenshot tests

# Todos

- [ ] Add entry to changelog (if necessary).
  • Loading branch information
coskucinkilic authored Oct 7, 2024
1 parent cbb394c commit 08f2239
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions frontend/src/lib/components/neurons/NnsNeuronAge.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,3 @@
</KeyValuePair>
{/if}
</TestIdWrapper>

<style lang="scss">
@use "@dfinity/gix-components/dist/styles/mixins/fonts";
.label {
color: var(--description-color);
}
</style>
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 08f2239

Please sign in to comment.