Backend: Simplify HeapInd #2064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the “HeapInd” way of handling variables (a local that points to a MutBox, used for captured mutable data) was overly general, and that caused bugs in @osa1’s refactorings in #1931. I think I had fancy plans here, but right now I am not using any other `offset` than `MutBox.field`, so let’s simplify the code accordingly.
|
This PR does not affect the produced WebAssembly code. |
which means more of #1931 might work
nomeata
force-pushed
the
joachim/simpler-HeapInd
branch
from
d7a1079 to
1764904
Compare
ggreif
reviewed
Oct 23, 2020
ggreif
reviewed
Oct 23, 2020
Co-authored-by: Gabor Greif <gabor@dfinity.org>
|
LGTM, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the “HeapInd” way of handling variables (a local that points to a
MutBox, used for captured mutable data) was overly general, and that
caused bugs in @osa1’s refactorings in #1931.
I think I had fancy plans here, but right now I am not using any other
offsetthanMutBox.field, so let’s simplify the code accordingly.