feat: [MR-636] Add size limits as fields to the stream builder #3885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stiegerc
changed the title
…_to_stream_builder
stiegerc
changed the title
stiegerc
commented
Feb 11, 2025
|
I don't see the need for a test here, since there already are tests for different limits for the stream builder and I didn't change any of the behaviour, it's just that now internal fields are used rather than the constants directly, but these fields are initialized using the same constants from before. Only for |
stiegerc
changed the title
michael-weigelt
approved these changes
Feb 11, 2025
stiegerc
changed the title
…ity/ic into add_stream_limits_to_stream_builder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The driver behind this change is to make smaller streams possible in state machine tests and also unit or prop tests. But for state machine tests especially, having to fill up an entire stream with 10k filler requests just to test something at capacity takes a long time.
Since this change makes the stream limit constants public, removing the duplicate MAX_STREAM_MESSAGES in the payload builder as a small additional change makes sense here (even though it's not strictly related).