Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(crypto): CRP-2665 make ic-cdk optional and support wasm+js env in ic-validator-ingress-message #3369

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

fspreiss
Copy link
Member

@fspreiss fspreiss commented Jan 8, 2025

Adapts ic-validator-ingress-message to support Javascript WASM environments for Cargo builds via a new feature js, and also makes ic-cdk optional, but still keeps ic-cdk enabled by default, to keep backwards compatibility.

Both

  • cargo build -p ic-validator-ingress-message --target=wasm32-unknown-unknown --no-default-features --features=js and
  • cargo build -p ic-validator-ingress-message --target=wasm32-unknown-unknown --features=js

succeed.

Note that cargo build -p ic-validator-ingress-message --target=wasm32-unknown-unknown fails because getrandom is not supported for wasm*-unknown-unknown targets. Canisters that want to use ic-validator-ingress-message have to manually fix this, for example by using our ic-crypto-getrandom-for-wasm crate. There is also ic-validator-ingress-message-test-canister to test the usage of ic-validator-ingress-message from a canister.

@github-actions github-actions bot added the feat label Jan 8, 2025
@fspreiss fspreiss changed the title feat(crypto): CRP-2665 support wasm+js env for ic-validator-ingress-message feat(crypto): CRP-2665 make ic-cdk optional and support wasm+js env in ic-validator-ingress-message Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant