Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make CanisterSig public, and add a parsing function #12

Merged
merged 2 commits into from
Jul 11, 2024
Merged

Make CanisterSig public, and add a parsing function #12

merged 2 commits into from
Jul 11, 2024

Conversation

przydatek
Copy link
Contributor

Make CanisterSig-struct public, so that it can be used elsewhere.
Add parse_canister_sig_cbor for parsing serialised canister signatures.

@przydatek przydatek requested a review from a team as a code owner July 11, 2024 14:09
frederikrothenberger
frederikrothenberger approved these changes Jul 11, 2024
View reviewed changes
Copy link

@frederikrothenberger frederikrothenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm!

@frederikrothenberger frederikrothenberger merged commit b6fce5b into main Jul 11, 2024
5 checks passed
@frederikrothenberger frederikrothenberger deleted the bartosz/canister-sig branch July 11, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frederikrothenberger frederikrothenberger frederikrothenberger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@przydatek @frederikrothenberger