feat: cordon features #966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pietrodimarco-dfinity
approved these changes
Sep 27, 2024
sasa-tomic
approved these changes
Sep 30, 2024
sasa-tomic
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to cordon features by adding entries to the new
cordoned_features.yamlfile. Currently it will exclude from the pool of available nodes all the nodes with the cordoned feature. It will not attempt to remove all healthy nodes (in the subnet) that have said feature, it will just prevent entering of the new nodes with those features.When removing nodes from the subnet and when they are added back to the available pool, if the removed node contains cordoned features it will not be added to the available pool. It means that some of the nodes containing cordoned features could be removed if the business rules are met.