Scrape GuestOS metrics-proxy and clean up issues in multiservice-discovery. #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Close this and rename the branch to |
DFINITYManu
changed the base branch from
main
to
container-metricsproxyguestscrape
DFINITYManu
merged commit 2cf0927
into
container-metricsproxyguestscrape
3 checks passed
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 25, 2024
…overy. #91 (#93) * Scrape GuestOS metrics-proxy and clean up redundancies in observability code. * Fix test I broke. * Ensure boundary nodes cannot be added with unsupported services. * Add convenience method to simplify IP address getting. * Eliminate need for mutability in a lot of the code. * Avoid some mutability in export targets generator. * Add replica and orchestrator as valid boundary node job types. * Fix path overwrite sec issue, allow replacing NNS definitions with PUT, and add README. * Fix typos in test. * Remove unhelpful assert. * Disable failing test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
multiservice-discoverywas incorrectly discovering HostOS node exporter as GuestOS node exporter.The matter has been corrected. This is a sample diff from its prior output and the current output. Note IP address of
host_node_exporterin the prior scrape.