feat: overriding ic admin versions #864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds possibility to specify a version of
ic-adminto wrap.Previously we were forced to rely on governance canister version and fallback to a default.
Now we have the full control. The default is
from-governancewhich is the same behavior as before.To run dre with
ic-adminwith governance version:To run dre with
ic-adminfrom default version that is updated when we update deps:To run dre with
ic-adminfrom a specific commit we can use:Also its possible to specify everything with an env variable
IC_ADMIN_VERSION