Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node providers in Node Rewards canister #759

Merged
merged 9 commits into from
Aug 21, 2024

Conversation

pietrodimarco-dfinity
Copy link
Contributor

@pietrodimarco-dfinity pietrodimarco-dfinity commented Aug 20, 2024

Changes:

  • Adds node providers fetching and storage per node
  • Modifies NodeRewardsResponse to return the node_provider_id per node

@pietrodimarco-dfinity pietrodimarco-dfinity requested a review from a team as a code owner August 20, 2024 17:33
@pietrodimarco-dfinity pietrodimarco-dfinity changed the title Add Node Providers from registry canister Improve node-rewards canister Aug 20, 2024
@pietrodimarco-dfinity pietrodimarco-dfinity changed the title Improve node-rewards canister Add node providers in Node Rewards canister Aug 20, 2024
Copy link
Member

@sasa-tomic sasa-tomic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@pietrodimarco-dfinity pietrodimarco-dfinity merged commit 7d06094 into main Aug 21, 2024
4 checks passed
@pietrodimarco-dfinity pietrodimarco-dfinity deleted the add-node-provider-from-registry-canister branch August 21, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants