Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dre): [DRE-237] Send desktop notifications when (not) voting with dre tool #711

Merged

Conversation

sasa-tomic
Copy link
Member

Will invoke a system notification binary if it exists, or complain and continue if the system notification binary does not exist.
Will try to use

Closes DRE-237

…h dre tool

Will invoke a system notification binary if it exists, or complain and continue if the system notification binary does not exist.
Will try to use
* notify-send on Linux https://opensource.com/article/22/1/linux-desktop-notifications
* osascript on MacOS https://smallsharpsoftwaretools.com/tutorials/macos-notifications/

Closes DRE-237
@sasa-tomic sasa-tomic requested a review from a team as a code owner August 13, 2024 13:14
Copy link
Contributor

@DFINITYManu DFINITYManu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small feature request: notify-send supports icons (although not sure arbitrary bitmaps as icons). Would it not be awesome if the notification had a cool IC icon?

@sasa-tomic sasa-tomic enabled auto-merge (squash) August 13, 2024 14:49
@sasa-tomic sasa-tomic merged commit 5d4f8f2 into main Aug 13, 2024
4 checks passed
@sasa-tomic sasa-tomic deleted the DRE-237-send-desktop-notifications-from-dre-tooling-when-v branch August 13, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants