Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: changing default behavior if cursor is not present #466

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

NikolaMilosa
Copy link
Contributor

Previously, if the __CURSOR wasn't present we would start fetching only the newest logs. While convenient it we had some issues where we would lose logs or have to refetch from the start and this would help us achieve that more easily. When the new target is added we will start fetching logs from the start of their journal

@NikolaMilosa NikolaMilosa requested a review from a team as a code owner June 7, 2024 11:58
Copy link
Member

@sasa-tomic sasa-tomic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NikolaMilosa NikolaMilosa merged commit 1d39289 into main Jun 7, 2024
4 checks passed
@NikolaMilosa NikolaMilosa deleted the nm-changing-default-behavior branch June 7, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants