Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reconciler): Use new subcommand of ic-admin for revising the GuestOS versions #1264

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DFINITYManu
Copy link
Contributor

@DFINITYManu DFINITYManu commented Feb 3, 2025

Additionally, we no longer place the proposal forum post link in the summary of the proposal. In its stead, we place the forum post link in the field of the proposal designated for it.

Here is confirmation of how the command that gets invoked looks like now (obviously this is a dry-run):

 2025-02-03T13:58:59.777Z INFO  dre > Running version 0.5.6-e77e673721b5f725cc16d355f405d4a85ef098e7
 2025-02-03T13:58:59.826Z INFO  dre::ic_admin > Using ic-admin 03393bc817da78cdc27190eaa388b8f6f8990365 because lock file was created less than 24 hours ago
thread 'tokio-runtime-worker' panicked at rs/cli/src/auth.rs:266:116:
called `Option::unwrap()` on a `None` value
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
 2025-02-03T13:58:59.910Z WARN  dre::ctx      > Couldn't detect neuron due to: task 15 panicked with message "called `Option::unwrap()` on a `None` value"
 2025-02-03T13:58:59.910Z WARN  dre::ctx      > Falling back to Anonymous for dry-run
 2025-02-03T13:58:59.910Z INFO  dre::ic_admin > running ic-admin: 
$ /home/manuel/bin/ic-admin.revisions/03393bc817da78cdc27190eaa388b8f6f8990365/ic-admin \
    --secret-key-pem /home/manuel/.config/dfx/identity/test_neuron_1/identity.pem \
    --nns-urls https://ic0.app/ \
  propose-to-revise-elected-guestos-versions \
    --proposal-title 'Elect new IC/Replica revision (commit 0000000)' \
    --summary 'Fake changelog' \
    --dry-run \
    --release-package-sha256-hex 0000000000000000000000000000000000000000 \
    --release-package-urls https://doesntmatter.com/ \
    --replica-version-to-elect 0000000000000000000000000000000000000000 \
    --proposal-url https://forum.dfinity.org/t/proposal-to-elect-new-release-rc-2024-03-27-23-01/29042/7 \
    --proposer 123
Using NNS URLs: ["https://ic0.app/"]

…tOS versions.

Additionally, we no longer place the proposal forum post link in the summary of the proposal.
In its stead, we place the forum post link in the field of the proposal designated for it.
@DFINITYManu DFINITYManu requested a review from a team as a code owner February 3, 2025 13:56
Copy link
Contributor

@NikolaMilosa NikolaMilosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need to support the old proposal type? I highly doubt we will roll back to that. Also would be nice to use dre api for that dre version revise-elected-versions guest-os ... although it would require some tweaking to accept a payload from argument instead of prompting user in $EDITOR

Copy link
Member

@sasa-tomic sasa-tomic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but as Nikola commented, I'd recommend that we remove the old ic-admin commands since we won't need them in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants