Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: AgentBuilder::with_background_dynamic_routing is async #634

Merged
merged 3 commits into from
Feb 4, 2025

Conversation

sesi200
Copy link
Contributor

@sesi200 sesi200 commented Feb 3, 2025

Description

AgentBuilder method with_background_dynamic_routing is async for no reason.

Reported on the forum

How Has This Been Tested?

not tested

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@sesi200 sesi200 requested a review from a team as a code owner February 3, 2025 10:18
@sesi200 sesi200 changed the title fix: Agent::with_background_dynamic_routing is async fix: AgentBuilder::with_background_dynamic_routing is async Feb 3, 2025
@sesi200 sesi200 enabled auto-merge (squash) February 3, 2025 12:03
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Linwei Shang <linwei.shang@dfinity.org>
@sesi200 sesi200 merged commit 6a0d96e into main Feb 4, 2025
25 checks passed
@sesi200 sesi200 deleted the severin/async-builder branch February 4, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants