Proposal: Account.principal → Account.owner #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The working group decided to rename Account.principal to Account.owner because "principal" is a reserved symbol in Candid, which might create unnecessary friction for people trying to call the ledger using dfx.
dfinity-bot
pushed a commit
to dfinity/ic
that referenced
this pull request
Aug 9, 2022
[FI-376] ICRC-1: modernize the Account type This change updates the Account type and the TransferArg structure to match the latest changes in the standard. Related ICRC-1 PRs: * dfinity/ICRC-1#26 * dfinity/ICRC-1#41 In essence, we rename `Account.of` -> `Account.owner` and use the `to : Account` field in TransferArg instead of `to_principal : principal` and `to_subaccount : opt Subaccount` fields. See merge request dfinity-lab/public/ic!6824
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The working group decided to rename
Account.principaltoAccount.ownerbecause "principal" is a reserved symbol in Candid, which might create
unnecessary friction for people trying to call the ledger using dfx.