Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: icrc1_minting_account endpoint #29

Merged
merged 6 commits into from
Aug 2, 2022

Conversation

roman-kashitsyn
Copy link
Contributor

This change introduces the notion of a minting account and adds
an endpoint that returns the current minting account of the ledger.

This change introduces the notion of a minting account and adds
an endpoint that returns the current minting account of the ledger.
@lastmjs
Copy link
Contributor

lastmjs commented Jul 26, 2022

I'm starting to think that the minting account should be an extension to ICRC-1. Not all tokens currently have a minting account, and I foresee not all tokens needing/wanting a minting account in the future.

It's a valid use-case to want a fixed supply of tokens to exist at launch.

@dansteren
Copy link
Contributor

I'm starting to think that the minting account should be an extension to ICRC-1. Not all tokens currently have a minting account, and I foresee not all tokens needing/wanting a minting account in the future.

I agree with Jordan and would prefer we leave this to an extension. If however we are in the minority, I suggest we at least make the return type an opt Account to accommodate those scenarios.

@roman-kashitsyn
Copy link
Contributor Author

roman-kashitsyn commented Jul 26, 2022

I'm starting to think that the minting account should be an extension to ICRC-1. Not all tokens currently have a minting account, and I foresee not all tokens needing/wanting a minting account in the future.

It's a valid use-case to want a fixed supply of tokens to exist at launch.

That's a good point.

Maybe we could move this information into metadata?

We could add a new Value variant:

type Value = variant { ...; Principal : principal };

and return record { "icrc1:minting_account"; variant { Principal = ... } } metadata entry for ledgers that have a minting account.

@roman-kashitsyn
Copy link
Contributor Author

roman-kashitsyn commented Aug 2, 2022

The working group discussed this feature today.
The agreement is to add the icrc1_minting_account with an optional result and extend it later with the corresponding metadata entry once we define a textual representation for structured accounts.

@roman-kashitsyn roman-kashitsyn merged commit 5a04f87 into main Aug 2, 2022
@roman-kashitsyn roman-kashitsyn deleted the roman-minting-account branch August 2, 2022 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants