EES-5545 Cleanup for ReleaseDataUploadsSection
#5569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsim
requested review from
benoutram,
mmoalin,
bennettstuart,
mmyoungman,
rianski,
tomjonesdev,
amyb-hiveit and
jack-hive
ntsim
changed the title
ReleaseDataUploadsSection
ntsim
force-pushed
the
ees-5545-cleanup
branch
from
f9a5a9e to
4d84ce9
Compare
EES-5545 Move delete file plan modal into separate component
- Fixes incorrect uses of `waitFor` - Swaps `waitFor` uses with `findByText` - Various other cleanup
ntsim
force-pushed
the
ees-5545-cleanup
branch
from
4d84ce9 to
d9f3b92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR performs some cleanup in preparation for a second PR for EES-5545 (#5571):
ReleaseDataUploadsSectionDeleteDataFileModalinto its own component to stop it cluttering upReleaseDataUploadsSectionReleaseDataUploadsSectiontests:waitForblocks usinggetByRoleselectorswaitForblocks withfindBy*selectorsgetTableRowas it assumes a single table (there will be two tables in the next PR)