EES-5800 Update DataGuidanceFileWriter.DoWrite to use Release title #5539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jack-hive
approved these changes
Jan 21, 2025
benoutram
added
do not merge
jack-hive
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
DataGuidanceFileWriter.DoWriteto write outRelease.Titlein the second line. Previously this consisted of properties ofReleaseVersionformatted as{ReleaseVersion.Year} {ReleaseVersion.TimePeriodCoverage}.This fixes a problem where a release label (if set) is not present in the second line of the data guidance.
Release.Titleis a calculated property containing the label.