EES-5678: RebuildIndexes procedure calls update statistics regardless of timeout #5529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomjonesdev
requested review from
benoutram,
duncan-at-hiveit,
mmyoungman and
jack-hive
benoutram
reviewed
Jan 16, 2025
...n.ExploreEducationStatistics.Data.Model/Migrations/20250108173703_Routine_RebuildIndexes.sql
Show resolved
Hide resolved
....Model/Migrations/20250108173703_EES5678_RebuildIndexesTimeoutDoesNotSkipTableStatsUpdate.cs
Outdated
Show resolved
Hide resolved
...n.ExploreEducationStatistics.Data.Model/Migrations/20250108173703_Routine_RebuildIndexes.sql
Outdated
Show resolved
Hide resolved
...cation.ExploreEducationStatistics.Data.Model/Migrations/Current_Routine_UpdateStatistics.sql
Outdated
Show resolved
Hide resolved
benoutram
reviewed
Jan 17, 2025
...cation.ExploreEducationStatistics.Data.Model/Migrations/Current_Routine_UpdateStatistics.sql
Outdated
Show resolved
Hide resolved
...cation.ExploreEducationStatistics.Data.Model/Migrations/Current_Routine_UpdateStatistics.sql
Outdated
Show resolved
Hide resolved
...cation.ExploreEducationStatistics.Data.Model/Migrations/Current_Routine_UpdateStatistics.sql
Outdated
Show resolved
Hide resolved
...ducation.ExploreEducationStatistics.Data.Model/Migrations/Current_Routine_RebuildIndexes.sql
Outdated
Show resolved
Hide resolved
...ducation.ExploreEducationStatistics.Data.Model/Migrations/Current_Routine_RebuildIndexes.sql
Show resolved
Hide resolved
tomjonesdev
force-pushed
the
EES-5678
branch
4 times, most recently
from
725702c to
fb3c485
Compare
benoutram
reviewed
Jan 17, 2025
src/GovUk.Education.ExploreEducationStatistics.Data.Api/appsettings.Development.json
Outdated
Show resolved
Hide resolved
....Model/Migrations/20250108173703_EES5678_RebuildIndexesTimeoutDoesNotSkipTableStatsUpdate.cs
Outdated
Show resolved
Hide resolved
benoutram
approved these changes
Jan 20, 2025
…op RebuildIndexesUpdateStatistics table, remove skipped re-index messaging, RebuildIndexes procedure calls update statistics regardless of timeout.
benoutram
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a migration which updates the behaviour of the
RebuildIndexesprocedure on the statistics database. The changes consist of:RebuildIndexesUpdateStatisticstable, as this was no longer deemed usefulRebuildIndexesprocedure updates the statistics regardless of timeout.