EES-5787 Allow request Chart.Title to be null #5520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmyoungman
changed the title
| @@ -70,7 +70,7 @@ public Validator() | |||
| { | |||
| chart | |||
| .RuleFor(request => request.Title) | |||
| .NotEmpty() | |||
| .NotEmpty().When(request => request.Title != null) | |||
There was a problem hiding this comment.
Hey @mmyoungman - could this not just be:
chart
.RuleFor(request => request.Title)
.MaximumLength(220);
There was a problem hiding this comment.
I think this would allow title to be an empty string?
I've switched to
chart
.RuleFor(request => request.Title)
.Length(1, 220);
duncan-at-hiveit
approved these changes
Jan 10, 2025
N-moh
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug introduced in EES-5731. A chart couldn't be created because the backend validation didn't allow a null chart title.
When creating a chart, the chart title is only provided in the request if the user is providing an alternative chart title. Otherwise, the chart title is generated by the backend (I believe).