Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EES-4902 Fix react-leaflet not being transpiled by Jest #5502

Merged
merged 4 commits into from
Jan 8, 2025
Merged

EES-4902 Fix react-leaflet not being transpiled by Jest #5502

merged 4 commits into from
Jan 8, 2025

Conversation

ntsim
Copy link
Collaborator

@ntsim ntsim commented Jan 7, 2025 •
edited
Loading

This PR fixes react-leaflet not being transpiled by Jest causing us to have to skip or comment out various bits of test code.

Other changes

  • Adds missing intersection-observer polyfill for tests

@ntsim ntsim requested a review from bennettstuart January 7, 2025 14:21
@ntsim ntsim mentioned this pull request Jan 7, 2025
Merged
@ntsim ntsim changed the base branch from EES-5542 to dev January 7, 2025 15:33
bennettstuart
bennettstuart approved these changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@bennettstuart bennettstuart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for shifting this into dev

@ntsim ntsim merged commit f3d9f3c into dev Jan 8, 2025
10 checks passed
@ntsim ntsim deleted the ees-4902 branch January 8, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bennettstuart bennettstuart bennettstuart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ntsim @bennettstuart