Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EES-5537 EES-5500 Notifier ContentDB connection and archived subscriptions fixes #5290

Merged
merged 5 commits into from
Oct 1, 2024

Conversation

mmyoungman
Copy link
Collaborator

@mmyoungman mmyoungman commented Sep 27, 2024

This PR does three things

  • Allows the Notifier to connect to the Content DB
  • When unsubscribing a user, we now also remove any subscriptions from associated archived subscriptions.
  • Fixes the unsubscribe link for subscribers to archived publications

Details for why we decided to create the DB connection for Notifier are in the comments in EES-5500. The TLDR is that we consider it better to open a Content DB connection for Notifier than continue to pass everything Notifier needs in requests. And now we have a Content DB connection in Notifier, this opens up the possibility for other simplifications, as Notifier can now fetch the data it needs itself.

🚨 This PR requires faffy deploy steps detailed in EES-5537 🚨

edit: For this to all work, I had to manually create a "login" every database we use - so the local test data, dev, test, preprod and prod Content DBs:
CREATE LOGIN notifier WITH PASSWORD = 'ourbrandnewsecurepassword';

@mmyoungman mmyoungman changed the title EES-5537 EES-5500 Notifier ContentDB connection and also removed archived subscriptions when unsubscribing EES-5537 EES-5500 Notifier ContentDB connection and also remove archived subscriptions when unsubscribing Sep 27, 2024
@mmyoungman mmyoungman changed the title EES-5537 EES-5500 Notifier ContentDB connection and also remove archived subscriptions when unsubscribing EES-5537 EES-5500 Notifier ContentDB connection and archived subscriptions fixes Sep 30, 2024
@mmyoungman mmyoungman force-pushed the EES-5537 branch 2 times, most recently from ef36167 to 5e5f99d Compare September 30, 2024 14:18
@mmyoungman mmyoungman merged commit d097d76 into dev Oct 1, 2024
7 checks passed
@mmyoungman mmyoungman deleted the EES-5537 branch October 1, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants