EES-5537 EES-5500 Notifier ContentDB connection and archived subscriptions fixes #5290
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does three things
Details for why we decided to create the DB connection for Notifier are in the comments in EES-5500. The TLDR is that we consider it better to open a Content DB connection for Notifier than continue to pass everything Notifier needs in requests. And now we have a Content DB connection in Notifier, this opens up the possibility for other simplifications, as Notifier can now fetch the data it needs itself.
🚨 This PR requires faffy deploy steps detailed in EES-5537 🚨
edit: For this to all work, I had to manually create a "login" every database we use - so the local test data, dev, test, preprod and prod Content DBs:
CREATE LOGIN notifier WITH PASSWORD = 'ourbrandnewsecurepassword';