EES-XXXX - fixed failing Public API test which was expecting an inval… #5277
Conversation
duncan-at-hiveit
force-pushed
the
EES-XXXX-fix-ui-tests-with-failing-dataset-import
branch
2 times, most recently
from
396a9ef to
a18165b
Compare
| time_period,time_identifier,geographic_level,country_code,country_name,region_name,region_code,URN,old_la_code,la_name,Estab,school_name,LAEstab,OpenDate,sex_of_school,Phase-type_grouping,type_of_esstablishment,middle_school,all_through_school,hospital_school,Denomination,Denomination_Detail,admissions_policy,district_administrative_code,district_administrative_name,parlc_code,parlc_name,ward_code,ward_name,urban_rural,school_postcode,new_la_code,ethnicity,FSM,Language,headcount,percent_of_pupils | ||
| 201920,Academic year,Local authority,E92000001,England,East Midlands,E12000004,,856,Leicester,,,,,,Pupil referral unit,,,,,,,,,,,,,,,,E06000016,Asian - Pakistani,Total,Total,0,0 |
There was a problem hiding this comment.
Is it necessary to have all of the columns of this data set? I think the more columns there are, the less obvious it is to someone looking at it to realise why it's 'invalid'.
I think at the moment that this is a cut down version of the data set @saicharan2789 added originally, which has multiple issues with it, and while it could be possible that an analyst attempts to create an API data set from something like this, if we are trying to force the processing to fail, why don't we add a small dataset with just one known cause of failure into it?
There was a problem hiding this comment.
Might also be good to make it clear what the issue with data set is in the name of the file
There was a problem hiding this comment.
As discussed on Slack, this'll be tackled in a subsequent follow-up piece of work which'll allow us to remove the CSV
…id file for Public API import. Refactored various data file import Robot keywords to reuse various checks.
duncan-at-hiveit
force-pushed
the
EES-XXXX-fix-ui-tests-with-failing-dataset-import
branch
from
a18165b to
375fc24
Compare
duncan-at-hiveit
deleted the
EES-XXXX-fix-ui-tests-with-failing-dataset-import
branch
This PR:
public_api_restricted.robotto avoid warnings about duplicate test names within a single suite.