EES-4490: Add theme to all publications #5269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomjonesdev
requested review from
benoutram,
ntsim,
duncan-at-hiveit,
bennettstuart and
mmyoungman
tomjonesdev
force-pushed
the
EES-4490-1
branch
from
5a72797 to
1aee989
Compare
...tatistics.Admin/Migrations/ContentMigrations/20240916141644_EES4490_AddThemeToPublication.cs
Show resolved
Hide resolved
src/explore-education-statistics-admin/src/components/form/FormFieldThemeTopicSelect.tsx
Show resolved
Hide resolved
src/GovUk.Education.ExploreEducationStatistics.Admin/Services/PublicationService.cs
Show resolved
Hide resolved
src/GovUk.Education.ExploreEducationStatistics.Admin/Services/PublicationService.cs
Show resolved
Hide resolved
...tatistics.Admin/Migrations/ContentMigrations/20240916141644_EES4490_AddThemeToPublication.cs
Outdated
Show resolved
Hide resolved
tomjonesdev
force-pushed
the
EES-4490-1
branch
5 times, most recently
from
95b809f to
1bdd037
Compare
duncan-at-hiveit
approved these changes
Sep 24, 2024
tomjonesdev
force-pushed
the
EES-4490-1
branch
from
1bdd037 to
694672d
Compare
…t-fix EES-4490 - added test theme id to UI test code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
Themeproperty directly to aPublication, in preparation for the removal ofTopic.The work includes:
Publicationcolumn and populate existing records with the correct theme ID, andIt was fairly awkward deciding which aspects could/should be changed in advance of the removal of topics, and which should remain, as the affected entities are inherently linked, and removing or changing them could break existing functionality until the next piece of work to remove topics is completed.