EES-4490: Add theme to all publications #5269
Open
+2,465
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomjonesdev
requested review from
benoutram,
ntsim,
duncan-at-hiveit,
bennettstuart and
mmyoungman
tomjonesdev
force-pushed
the
EES-4490-1
branch
from
5a72797
to
1aee989
Compare
| name: "FK_Publications_Topics_TopicId", | ||
| table: "Publications"); | ||
|
|
||
| migrationBuilder.Sql(@" |
There was a problem hiding this comment.
After this point, could we then add a foreign key constraint to this column, once all of the correct values are populated?
There was a problem hiding this comment.
A foreign key was added automatically through changes to the class (see the snapshot file to see if that's what you meant).
There was a problem hiding this comment.
But I still think that you need to add the SQL to enforce a foreign key. The snapshot update doesn't create SQL commands itself - it's just a mechanism to let the next migration know what has changed since the last migration was created, as far as I know. Would you mind checking in your DB to see if a foreign key constraint is created?
src/explore-education-statistics-admin/src/components/form/FormFieldThemeTopicSelect.tsx
Show resolved
Hide resolved
src/GovUk.Education.ExploreEducationStatistics.Admin/Services/PublicationService.cs
Show resolved
Hide resolved
src/GovUk.Education.ExploreEducationStatistics.Admin/Services/PublicationService.cs
Show resolved
Hide resolved
...tatistics.Admin/Migrations/ContentMigrations/20240916141644_EES4490_AddThemeToPublication.cs
Outdated
Show resolved
Hide resolved
tomjonesdev
force-pushed
the
EES-4490-1
branch
4 times, most recently
from
826d2f7
to
95b809f
Compare
tomjonesdev
force-pushed
the
EES-4490-1
branch
from
95b809f
to
1bdd037
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
Themeproperty directly to aPublication, in preparation for the removal ofTopic.The work includes:
Publicationcolumn and populate existing records with the correct theme ID, andIt was fairly awkward deciding which aspects could/should be changed in advance of the removal of topics, and which should remain, as the affected entities are inherently linked, and removing or changing them could break existing functionality until the next piece of work to remove topics is completed.