EES-5382 hotfix remove devops spn from key vault role assignment #5243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as this is a prerequisite role to being able to initiate an infrasatructure deploy
tomjonesdev
approved these changes
Sep 13, 2024
duncan-at-hiveit
deleted the
EES-5382-hotfix-remove-devops-spn-from-key-vault-role-assignment
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
It would not necessarily have been a problem to keep it if the role assignments our code produces resulted in the same GUID-based name for the assignment that manual assignment produced, but they don't and as a result it would otherwise cause a "RoleASssignmentAlreadyExists" error.