Ees 5479 modularise bicep #5222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duncan-at-hiveit
force-pushed
the
EES-5479-modularise-bicep
branch
from
251b574
to
e6c4c75
Compare
benoutram
reviewed
Sep 9, 2024
infrastructure/templates/public-api/components/containerRegistry.bicep
Outdated
Show resolved
Hide resolved
infrastructure/templates/public-api/components/functionApp.bicep
Outdated
Show resolved
Hide resolved
infrastructure/templates/public-api/application/public-api/publicApiApp.bicep
Outdated
Show resolved
Hide resolved
infrastructure/templates/public-api/application/shared/postgreSqlFlexibleServer.bicep
Outdated
Show resolved
Hide resolved
benoutram
approved these changes
Sep 13, 2024
duncan-at-hiveit
force-pushed
the
EES-5479-modularise-bicep
branch
17 times, most recently
from
e35d097
to
bb6e9b1
Compare
…resources up-front in main.bicep rather than construct within each module.
…ve to administer it and pass through as parameters in main.bicep
…n types and used throughout templates. Calculate names in main.bicep and pass as parameter to the various application modules.
…r App identity into separate module so that we can create PSQL user for it prior to the Container App itself being rolled out. Removed temporary flag to skip deployment of PSQL for time saving as it appears issues are fixed. Added automation of PSQL entra id admins. Added parameter to locate resource group of ACR
… in orderr to perform Docker image pulls from Dev ACR
…ckend pool IP addresses using the Container App Environment FQDN
…ng tripped up by "Skipped" condition affecting the use of "succeeded()" check
…essful rollout to the Test Resource Group
…latform -> enabled" setting. Adding App Insights support into Container Apps.
duncan-at-hiveit
force-pushed
the
EES-5479-modularise-bicep
branch
from
bb6e9b1
to
2f415ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
main.bicepfile up into separate modules, one for each high-level resource being managed or referenced from the Public API infrastructure deploy.Resources are created in separate modules, and these modules are in turn separated between "shared" and "public-api" modules. Shared modules represent resources that can be used beyond the scope of the Public API e.g. generic Log Analytics Workspaces, or Container App Environments. They also house the ARM-template controlled resources for lookup purposes.
Resource names are now defined in each module using appropriate prefixes, and these are handed down to the Bicep modules in the
componentsfolder rather than being constructed within each of thecomponentsmodules. This has led to much more clarity in terms of the names that all of the various resources will take on in the deployment, rather than being buried down in low-level modules.