EES-5442 - updating file storage path to reflect updates to a next DataSetVersion's version number #5183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duncan-at-hiveit
force-pushed
the
EES-5442-update-version-in-file-storage-path-before-final-import
branch
2 times, most recently
from
df82a16 to
56b6634
Compare
ntsim
reviewed
Aug 28, 2024
| @@ -3,6 +3,7 @@ | |||
| using GovUk.Education.ExploreEducationStatistics.Public.Data.Processor.Extensions; | |||
| using GovUk.Education.ExploreEducationStatistics.Public.Data.Processor.Model; | |||
| using GovUk.Education.ExploreEducationStatistics.Public.Data.Services.Interfaces; | |||
| using LinqToDB; | |||
There was a problem hiding this comment.
Whilst this works, probably should be using SingleAsync from Microsoft.EntityFrameworkCore
There was a problem hiding this comment.
Aha good spot, updated thanks.
duncan-at-hiveit
force-pushed
the
EES-5442-update-version-in-file-storage-path-before-final-import
branch
2 times, most recently
from
9b27956 to
bef3172
Compare
…taSetVersions latest version prior to final import
duncan-at-hiveit
force-pushed
the
EES-5442-update-version-in-file-storage-path-before-final-import
branch
from
bef3172 to
c79f1a3
Compare
ntsim
approved these changes
Aug 28, 2024
duncan-at-hiveit
deleted the
EES-5442-update-version-in-file-storage-path-before-final-import
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Thereafter, the import process should continue as usual, using the now-updated file storage path.
I've added a convenience `DataSetVersion.DefautlNextVersion()" method which will give us the expected next version number of a DataSetVersion (using the existing implementation of updating the minor version). We can then use this method to assign a default version number to a brand new next DataSetVersion, plus use it again to get the default file storage path that may or may not need updating prior to completing the import process.